Skip to content

tests: Stop ignoring android in backtrace tests #147091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

tests: Stop ignoring android in backtrace tests #147091

wants to merge 1 commit into from

Conversation

@Enselic
Copy link
Member

@Enselic Enselic commented Sep 27, 2025

I suspect #17520 (comment) is not a problem any longer. Let's try.

r? @ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 27, 2025
@rust-log-analyzer

This comment was marked as outdated.

Sign in to view
@Urgau
Copy link
Member

Urgau commented Sep 27, 2025

@bors2 try jobs=arm-android

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Sep 27, 2025
@rust-bors
Auto merge of #147091 - Enselic:android-bt, r=<try>
e0abdd2 
tests: Stop ignoring android in backtrace tests

try-job: arm-android
@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Sep 27, 2025

The job arm-android failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
failures:

---- [ui] tests/ui/backtrace/line-tables-only.rs stdout ----

error: test did not exit with success! code=Some(101) so test would pass with `run-fail`
status: exit status: 101
command: RUSTC="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" RUST_TEST_THREADS="4" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools-bin/remote-test-client" "run" "1" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/backtrace/line-tables-only/a" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/backtrace/line-tables-only/auxiliary/libline_tables_only_helper.so"
--- stdout -------------------------------
uploaded "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/backtrace/line-tables-only/a", waiting for result
------------------------------------------
--- stderr -------------------------------
Backtrace [
    { fn: "main", file: "./checkout/tests/ui/backtrace/line-tables-only.rs", line: 43 },
    { fn: "call_once<fn(), ()>", file: "./rustc/FAKE_PREFIX/library/core/src/ops/function.rs", line: 250 },
    { fn: "__rust_begin_short_backtrace<fn(), ()>", file: "./rustc/FAKE_PREFIX/library/std/src/sys/backtrace.rs", line: 158 },
    { fn: "std::rt::lang_start::{{closure}}", file: "./rustc/FAKE_PREFIX/library/std/src/rt.rs", line: 206 },
    { fn: "main" },
]

thread 'main' (2234) panicked at /checkout/tests/ui/backtrace/line-tables-only.rs:36:5:
backtrace does not contain expected name foo
stack backtrace:
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
------------------------------------------

---- [ui] tests/ui/backtrace/line-tables-only.rs stdout end ----
---- [ui] tests/ui/backtrace/dylib-dep.rs stdout ----

error: test did not exit with success! code=Some(134) so test would pass with `run-crash`
status: exit status: 134
command: RUSTC="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" RUST_TEST_THREADS="4" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools-bin/remote-test-client" "run" "2" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/backtrace/dylib-dep/a" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/backtrace/dylib-dep/auxiliary/libdylib_dep_helper_aux.so" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/backtrace/dylib-dep/auxiliary/libdylib_dep_helper.so"
--- stdout -------------------------------
uploaded "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/backtrace/dylib-dep/a", waiting for result
died due to signal 6
------------------------------------------
--- stderr -------------------------------
-----------------------------------
looking for:
 /checkout/tests/ui/backtrace/dylib-dep.rs:74
 /checkout/tests/ui/backtrace/auxiliary/dylib-dep-helper.rs:18
 /checkout/tests/ui/backtrace/dylib-dep.rs:73
found:
Backtrace [
    { fn: "dylib_dep::verify", file: "./checkout/tests/ui/backtrace/dylib-dep.rs", line: 43 },
    { fn: "dylib_dep::main::{{closure}}", file: "./checkout/tests/ui/backtrace/dylib-dep.rs", line: 74 },
    { fn: "core::ops::function::FnOnce::call_once", file: "./rustc/FAKE_PREFIX/library/core/src/ops/function.rs", line: 250 },
    { fn: "dylib_dep::main", file: "./checkout/tests/ui/backtrace/dylib-dep.rs", line: 73 },
    { fn: "core::ops::function::FnOnce::call_once", file: "./rustc/FAKE_PREFIX/library/core/src/ops/function.rs", line: 250 },
    { fn: "std::sys::backtrace::__rust_begin_short_backtrace", file: "./rustc/FAKE_PREFIX/library/std/src/sys/backtrace.rs", line: 158 },
    { fn: "std::rt::lang_start::{{closure}}", file: "./rustc/FAKE_PREFIX/library/std/src/rt.rs", line: 206 },
    { fn: "std::rt::lang_start", file: "./rustc/FAKE_PREFIX/library/std/src/rt.rs", line: 205 },
    { fn: "main" },
]

thread 'main' (2231) panicked at /checkout/tests/ui/backtrace/dylib-dep.rs:57:9:
expected backtrace to contain /checkout/tests/ui/backtrace/auxiliary/dylib-dep-helper.rs
stack backtrace:
---

---- [ui] tests/ui/backtrace/dylib-dep.rs stdout end ----
---- [ui] tests/ui/backtrace/backtrace.rs stdout ----

error: test did not exit with success! code=Some(101) so test would pass with `run-fail`
status: exit status: 101
command: RUSTC="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" RUST_TEST_THREADS="4" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools-bin/remote-test-client" "run" "0" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/backtrace/backtrace/a"
--- stdout -------------------------------
uploaded "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/backtrace/backtrace/a", waiting for result
------------------------------------------
---
---- [ui] tests/ui/panics/issue-47429-short-backtraces.rs stdout ----
Saved the actual run.stderr to `/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/panics/issue-47429-short-backtraces/issue-47429-short-backtraces.run.stderr`
diff of run.stderr:

2 thread 'main' ($TID) panicked at $DIR/issue-47429-short-backtraces.rs:26:5:
3 explicit panic
4 stack backtrace:
-    0: std::panicking::begin_panic
-    1: issue_47429_short_backtraces::main
7 note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
---
---- [ui] tests/ui/panics/runtime-switch.rs stdout ----
Saved the actual run.stderr to `/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/panics/runtime-switch/runtime-switch.run.stderr`
diff of run.stderr:

2 thread 'main' ($TID) panicked at $DIR/runtime-switch.rs:30:5:
3 explicit panic
4 stack backtrace:
-    0: std::panicking::begin_panic
-    1: runtime_switch::main
7 note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
---
------------------------------------------

---- [ui] tests/ui/panics/runtime-switch.rs stdout end ----
---- [ui] tests/ui/panics/short-ice-remove-middle-frames-2.rs stdout ----
Saved the actual run.stderr to `/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/panics/short-ice-remove-middle-frames-2/short-ice-remove-middle-frames-2.run.stderr`
diff of run.stderr:

2 thread 'main' ($TID) panicked at $DIR/short-ice-remove-middle-frames-2.rs:61:5:
3 debug!!!
4 stack backtrace:
-    0: std::panicking::begin_panic
-    1: short_ice_remove_middle_frames_2::eight
-    2: short_ice_remove_middle_frames_2::seven::{{closure}}
-       [... omitted 3 frames ...]
-    3: short_ice_remove_middle_frames_2::fifth
-    4: short_ice_remove_middle_frames_2::fourth::{{closure}}
+    0: short_ice_remove_middle_frames_2::fifth
+    1: short_ice_remove_middle_frames_2::fourth::{{closure}}
11       [... omitted 4 frames ...]
-    5: short_ice_remove_middle_frames_2::first
-    6: short_ice_remove_middle_frames_2::main
-    7: core::ops::function::FnOnce::call_once
+    2: short_ice_remove_middle_frames_2::first
+    3: short_ice_remove_middle_frames_2::main
+    4: core::ops::function::FnOnce::call_once
15 note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
16 


---

thread 'main' (11250) panicked at /checkout/tests/ui/panics/short-ice-remove-middle-frames-2.rs:61:5:
debug!!!
stack backtrace:
   0: short_ice_remove_middle_frames_2::fifth
   1: short_ice_remove_middle_frames_2::fourth::{{closure}}
      [... omitted 4 frames ...]
   2: short_ice_remove_middle_frames_2::first
   3: short_ice_remove_middle_frames_2::main
   4: core::ops::function::FnOnce::call_once
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
------------------------------------------

---- [ui] tests/ui/panics/short-ice-remove-middle-frames-2.rs stdout end ----
---- [ui] tests/ui/panics/short-ice-remove-middle-frames.rs stdout ----
Saved the actual run.stderr to `/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/panics/short-ice-remove-middle-frames/short-ice-remove-middle-frames.run.stderr`
diff of run.stderr:

2 thread 'main' ($TID) panicked at $DIR/short-ice-remove-middle-frames.rs:57:5:
3 debug!!!
4 stack backtrace:
-    0: std::panicking::begin_panic
-    1: short_ice_remove_middle_frames::seven
-    2: short_ice_remove_middle_frames::sixth
-    3: short_ice_remove_middle_frames::fifth::{{closure}}
-       [... omitted 4 frames ...]
-    4: short_ice_remove_middle_frames::second
-    5: short_ice_remove_middle_frames::first::{{closure}}
-    6: short_ice_remove_middle_frames::first
-    7: short_ice_remove_middle_frames::main
-    8: core::ops::function::FnOnce::call_once
+    0: short_ice_remove_middle_frames::second
+    1: short_ice_remove_middle_frames::first::{{closure}}
+    2: short_ice_remove_middle_frames::first
+    3: short_ice_remove_middle_frames::main

@rust-bors
Copy link

rust-bors bot commented Sep 27, 2025

💔 Test for e0abdd2 failed: CI. Failed jobs:

@jieyouxu
Copy link
Member

jieyouxu commented Sep 29, 2025

I seem to recall backtraces like these are very unpredictable between platforms... and even between different runs on the same platform (e.g. on MSVC, but I also recall specifically on i686 windows-gnu tho that's no longer tested in CI).

@Enselic Enselic mentioned this pull request Sep 29, 2025
Open
@Enselic
Copy link
Member Author

Enselic commented Sep 29, 2025

Turns out backtraces on Android are still broken, see #17520 (comment) for details.

@Enselic Enselic closed this Sep 29, 2025
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Enselic @rust-log-analyzer @Urgau @jieyouxu @rustbot